sdk: lower compile times too by using async_trait less
#3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Who has two thumbs and wants to make a trait not use async_trait, and thus get rid of trait object safety?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3880 +/- ##
==========================================
- Coverage 84.10% 84.05% -0.05%
==========================================
Files 266 266
Lines 27724 27738 +14
==========================================
- Hits 23317 23316 -1
- Misses 4407 4422 +15 ☔ View full report in Codecov by Sentry. |
This divides compile times for matrix-sdk by 2, on my machine (33 seconds -> 16).
bnjbvr
force-pushed
the
bnjbvr/lower-compile-times-sdk
branch
from
fd287fd
to
1dbd6aa
Compare
|
Will fold with the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is slightly more controversial than #3879, since it makes the code slightly less legible. But it's pretty sweet in that it also divides the compiles times of matrix-sdk by more than two on my machine, from 33 seconds to 12 seconds.
With this PR and #3879, the overall build time for multiverse goes from 113 seconds (cold build cache) down to 65 seconds (cold build cache too).
See also: rust-lang/rust#87012